Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest | From | Boris Ostrovsky <> | Date | Tue, 2 Feb 2016 12:19:29 -0500 |
| |
On 02/02/2016 11:39 AM, David Vrabel wrote: > On 01/02/16 15:38, Boris Ostrovsky wrote: >> --- a/include/xen/xen.h >> +++ b/include/xen/xen.h >> @@ -29,6 +29,12 @@ extern enum xen_domain_type xen_domain_type; >> #define xen_initial_domain() (0) >> #endif /* CONFIG_XEN_DOM0 */ >> >> +#ifdef CONFIG_XEN_PVHVM >> +extern int xen_hvmlite; >> +#else >> +#define xen_hvmlite (0) >> +#endif > I think we want a feature set and not a single boolean here. There's > going to HVMlite variants (e.g., those with an emulated APIC to support > PCI passthrough and those without). > > So we test e.g., xen_hvm_feature(XEN_HVM_FEATURE_APIC), which would be > clear for a HVMlite guest without an (emulated) APIC.
I was thinking of eventually 's/xen_hvmlite/xen_pvh_domain/g' but this is better.
Then we need to export features via XENVER_get_features. Alternatively, we can provide them in the hypervisor CPUID leaf.
-boris
| |