lkml.org 
[lkml]   [2016]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 1/3] perf kvm: Introduce evsel as argument to perf_event__preprocess_sample
Date
HI acme,

Thanks for reviewing the patch.

On Tuesday 02 February 2016 02:23 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 22, 2016 at 11:28:10AM +0530, Ravi Bangoria escreveu:
>> This patch changes prototype of perf_event__preprocess_sample() with
>> additional argument evsel added at last.
>>
>> This change is required because perf_event__preprocess_sample()
>> function will use evsel to determine cpumode of samples for powerpc
>> architecture.
>>
>> Signed-off-by: Ravi Bangoria<ravi.bangoria@linux.vnet.ibm.com>
> Fixing these problems:
>
>
>
> CC /tmp/build/perf/ui/gtk/util.o
> util/event.c: In function ‘perf_event__preprocess_sample’:
> util/event.c:1302:26: error: unused parameter ‘evsel’ [-Werror=unused-parameter]
> struct perf_evsel *evsel)
> ^
> cc1: all warnings being treated as errors
> mv: cannot stat ‘/tmp/build/perf/util/.event.o.tmp’: No such file or directory
> /home/acme/git/linux/tools/build/Makefile.build:77: recipe for target '/tmp/build/perf/util/event.o' failed
> make[3]: *** [/tmp/build/perf/util/event.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> CC /tmp/build/perf/ui/gtk/helpline.o
> CC /tmp/build/perf/arch/common.o
> /home/acme/git/linux/tools/build/Makefile.build:116: recipe for target 'util' failed
> make[2]: *** [util] Error 2
> make[2]: *** Waiting for unfinished jobs....

Thanks for pointing this out. Actually I was not aware about this.

Will take care next time onwards.

Regards,
Ravi

\
 
 \ /
  Last update: 2016-02-02 10:41    [W:0.055 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site