Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH RESEND] mailbox: pcc: fix channel calculation in get_pcc_channel() | Date | Wed, 03 Feb 2016 02:27:14 +0100 |
| |
On Tuesday, February 02, 2016 11:29:22 AM Alexey Klimov wrote: > This patch fixes the calculation of pcc_chan for non-zero id. > After the compiler ignores the (unsigned long) cast the > pcc_mbox_channels pointer is type-cast and then the type-cast > offset is added which results in address outside of the range > leading to the kernel crashing. > > We might add braces and make it: > > pcc_chan = (struct mbox_chan *) > ((unsigned long) pcc_mbox_channels + > (id * sizeof(*pcc_chan))); > > but let's go with array approach here and use id as index. > > Tested on Juno board. > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > Acked-by: Ashwin Chaugule <ashwin.chaugule@linaro.org> > Signed-off-by: Alexey Klimov <alexey.klimov@arm.com>
Jassi said this was applied, so I'm not taking it.
Thanks, Rafael
| |