lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 8/12] cpufreq: governor: Make governor private data per-policy
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Subject: [PATCH] cpufreq: governor: Make governor private data per-policy
>
> Some fields in struct od_cpu_dbs_info_s and struct cs_cpu_dbs_info_s
> are only used for a limited set of CPUs. Namely, if a policy is
> shared between multiple CPUs, those fields will only be used for one
> of them (policy->cpu). This means that they really are per-policy
> rather than per-CPU and holding room for them in per-CPU data
> structures is generally wasteful. Also moving those fields into
> per-policy data structures will allow some significant simplifications
> to be made going forward.
>
> For this reason, introduce struct cs_policy_dbs_info and
> struct od_policy_dbs_info to hold those fields. Define each of the
> new structures as an extension of struct policy_dbs_info (such that
> struct policy_dbs_info is embedded in each of them) and introduce
> new ->alloc and ->free governor callbacks to allocate and free
> those structures, respectively, such that ->alloc() will return
> a pointer to the struct policy_dbs_info embedded in the allocated
> data structure and ->free() will take that pointer as its argument.
>
> With that, modify the code accessing the data fields in question
> in per-CPU data objects to look for them in the new structures
> via the struct policy_dbs_info pointer available to it and drop
> them from struct od_cpu_dbs_info_s and struct cs_cpu_dbs_info_s.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>
> This adds a header file for the definitions of data structures shared
> between ondemand and amd_freq_sensitivity.
>
> The latter is updated to look for the governor tunables in struct od_policy_dbs_info
> instead of struct od_cpu_dbs_info_s.
>
> ---
> drivers/cpufreq/amd_freq_sensitivity.c | 5 +---
> drivers/cpufreq/cpufreq_conservative.c | 34 +++++++++++++++++++++++++++++----
> drivers/cpufreq/cpufreq_governor.c | 7 ++----
> drivers/cpufreq/cpufreq_governor.h | 9 +-------
> drivers/cpufreq/cpufreq_ondemand.c | 34 +++++++++++++++++++++++----------
> drivers/cpufreq/cpufreq_ondemand.h | 26 +++++++++++++++++++++++++
> 6 files changed, 87 insertions(+), 28 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh

\
 
 \ /
  Last update: 2016-02-19 04:01    [W:0.107 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site