lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 08/14] KVM: x86: remove notifiers from PIT discard policy
    From
    Date


    On 17/02/2016 20:14, Radim Krčmář wrote:
    > + /* pit->pit_state.lock was overloaded to prevent userspace from getting
    > + * an inconsistent state after running multiple KVM_REINJECT_CONTROL
    > + * ioctls in parallel. Use a separate lock if that ioctl isn't rare.
    > + */
    > + mutex_lock(&pit->pit_state.lock);
    > + kvm_pit_set_reinject(pit, control->pit_reinject);
    > + mutex_unlock(&pit->pit_state.lock);

    ... so in patch 7 concurrent _writes_ of reinject are protected by the
    lock, but reads are done outside it (in pit_timer_fn). WDYT about
    making reinject an atomic_t?

    Paolo

    \
     
     \ /
      Last update: 2016-02-18 19:21    [W:4.137 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site