lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/9] ARM: make free_memmap as __init
On Thu, 18 Feb 2016, Arnd Bergmann wrote:

> free_memmap is an inline function, but gcc may choose to ignore that
> when CONFIG_OPTIMIZE_INLINING is set. In that case it is put in the
> .text section, causing a kbuild warning:
>
> WARNING: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in reference from the function free_memmap() to the function .init.text:__memblock_free_early()
> The function free_memmap() references
> the function __init __memblock_free_early().
> This is often because free_memmap lacks a __init
> annotation or the annotation of __memblock_free_early is wrong.
>
> FATAL: modpost: Section mismatches detected.
> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
>
> This marks the function both inline and __init, which is a
> correct annotation and avoids the problem.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Nicolas Pitre <nico@linaro.org>

> ---
> arch/arm/mm/init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 370581aeb871..a4db267c35b2 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -330,7 +330,7 @@ static inline void poison_init_mem(void *s, size_t count)
> *p++ = 0xe7fddef0;
> }
>
> -static inline void
> +static inline void __init
> free_memmap(unsigned long start_pfn, unsigned long end_pfn)
> {
> struct page *start_pg, *end_pg;
> --
> 2.7.0
>
>

\
 
 \ /
  Last update: 2016-02-18 17:21    [W:0.040 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site