lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] mwifiex: parse chip specific gpio from device tree
On Tue, Feb 16, 2016 at 01:14:38AM -0800, Amitkumar Karwar wrote:
> From: Xinming Hu <huxm@marvell.com>
>
> This patch parse chip specific gpio parameter from device
> tree. Corresponding binding file is also updated.
>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> ---
> v4: Renamed "mwifiex,chip-gpio" to "marvell,wakeup-gpios"(Rob Herring/
> Arnd Bergmann)
> ---
> .../devicetree/bindings/net/wireless/marvell-sd8xxx.txt | 6 ++++--

Combine this with the DT change in the next patch.

> drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 9 +++++++++
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt b/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt
> index f7671ae..c337fab 100644
> --- a/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/marvell-sd8xxx.txt
> @@ -11,7 +11,9 @@ Optional properties:
> - marvell,caldata* : A series of properties with marvell,caldata prefix,
> represent Calibration data downloaded to the device during
> initialization. This is an array of unsigned values.
> -
> + - marvell,wakeup-gpios : Chip's wakeup gpio pin number. This needs to be downloaded
> + to to firmware. Chip notifies wifi wakeup signal to SOC
> + through this pin.

This is still confusing that it is not a GPIO from the host. I'd suggest
"marvell,wakeup-pin"

\
 
 \ /
  Last update: 2016-02-18 16:01    [W:0.074 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site