| Date | Tue, 16 Feb 2016 12:36:14 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv2 02/28] rmap: introduce rmap_walk_locked() |
| |
On Thu, Feb 11, 2016 at 10:52:08AM -0800, Andi Kleen wrote: > "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> writes: > > > rmap_walk_locked() is the same as rmap_walk(), but caller takes care > > about relevant rmap lock. > > > > It's preparation to switch THP splitting from custom rmap walk in > > freeze_page()/unfreeze_page() to generic one. > > Would be better to move all locking into the callers, with an > appropiate helper for users who don't want to deal with it. > Conditional locking based on flags is always tricky.
Hm. That's kinda tricky for rmap_walk_ksm()..
-- Kirill A. Shutemov
|