Messages in this thread | | | Date | Tue, 16 Feb 2016 09:24:31 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v2] x86/kernel: use pr_<level>() and dev_<level> |
| |
* Borislav Petkov <bp@alien8.de> wrote:
> > @@ -70,10 +70,10 @@ do { \ > > if (!(len)) \ > > break; \ > > \ > > - printk(KERN_DEBUG fmt, ##args); \ > > + pr_debug(fmt, ##args); \ > > for (j = 0; j < (len) - 1; j++) \ > > - printk(KERN_CONT "%02hhx ", buf[j]); \ > > - printk(KERN_CONT "%02hhx\n", buf[j]); \ > > + pr_cont("%02hhx ", buf[j]); \ > > + pr_cont("%02hhx\n", buf[j]); \ > > } \ > > } while (0) > > > > NAK the hell out of that hunk! > > Did you actually look at how pr_debug() is defined? > > Yeah, I don't think so. With your change, when I boot with > "debug-alternative" I get: > > ... > [ 0.064005] Last level dTLB entries: 4KB 512, 2MB 255, 4MB 127, 1GB 0 > [ 0.068005] e9 d5 3e d3 00 > [ 0.072004] e9 e8 92 21 ff > [ 0.075003] eb 11 0f 1f 00 > [ 0.077906] e8 c5 b6 30 00 > [ 0.084009] f3 48 0f b8 c7
Hm, so I suspect the other patch I already applied is buggy as well?
triton:~/tip> git log -1 -p 1b74dde7c47c | grep KERN_DEBUG - printk(KERN_DEBUG "tseg: %010llx\n", tseg); - printk(KERN_DEBUG "CPU%d: Thermal monitoring handled by SMI\n", cpu); -#define Dprintk(x...) do { if (debug_print) printk(KERN_DEBUG x); } while (0) - printk(KERN_DEBUG "After WB checking\n"); - printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n", - printk(KERN_DEBUG "After UC checking\n"); - printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n", - printk(KERN_DEBUG "After sorting\n"); - printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n", - printk(KERN_DEBUG "reg %d, base: %ld%cB, range: %ld%cB, type %s\n", - printk(KERN_DEBUG "original variable MTRRs\n"); - printk(KERN_DEBUG "New variable MTRRs\n"); - printk(KERN_DEBUG "New variable MTRRs\n"); - printk(KERN_DEBUG "Failed to setup IBS LVT offset, " - printk(KERN_DEBUG "No CPU node configured for IBS\n"); - printk(KERN_DEBUG "No EILVT entry available\n");
Thanks,
Ingo
| |