Messages in this thread Patch in this message | | | Date | Mon, 15 Feb 2016 23:53:53 -0800 | From | tip-bot for Wang Nan <> | Subject | [tip:perf/core] perf tools: Unlink entries from terms list |
| |
Commit-ID: a8adfceb389a0045e06af22517fa3326797b160a Gitweb: http://git.kernel.org/tip/a8adfceb389a0045e06af22517fa3326797b160a Author: Wang Nan <wangnan0@huawei.com> AuthorDate: Fri, 12 Feb 2016 16:31:23 -0300 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Fri, 12 Feb 2016 16:51:15 -0300
perf tools: Unlink entries from terms list
We were just freeing them, better unlink and init its nodes to catch bugs faster if we keep dangling references to them.
Signed-off-by: Wang Nan <wangnan0@huawei.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: He Kuang <hekuang@huawei.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Zefan Li <lizefan@huawei.com> Cc: pi3orama@163.com [ Spun off from another patch, use list_del_init() instead of list_del() ] Link: http://lkml.kernel.org/r/1454680939-24963-2-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/parse-events.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 813d9b2..133c8d2 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -2072,8 +2072,10 @@ void parse_events__free_terms(struct list_head *terms) { struct parse_events_term *term, *h; - list_for_each_entry_safe(term, h, terms, list) + list_for_each_entry_safe(term, h, terms, list) { + list_del_init(&term->list); free(term); + } } void parse_events_evlist_error(struct parse_events_evlist *data,
| |