lkml.org 
[lkml]   [2016]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 2/4] perf inject: add jitdump mmap injection support
    From
    On Fri, Feb 12, 2016 at 12:43 PM, Arnaldo Carvalho de Melo
    <acme@kernel.org> wrote:
    >
    > Em Fri, Feb 12, 2016 at 12:32:53PM -0800, Stephane Eranian escreveu:
    > > On Thu, Feb 11, 2016 at 2:16 PM, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
    > > > Em Mon, Feb 08, 2016 at 10:53:48AM -0800, Stephane Eranian escreveu:
    > > >> > I.e. the MMAP records for the kernel modules comes in ok, humm, because
    > > >> > probably you don't hook on PERF_RECORD_MMAP in perf-inject, just on MMAP2, and
    > > >> > in those the only difference is the second field, 0x6b98 -> 0x42a0, what is
    > > >> > that?
    >
    > > >> I have both MMAP and MMAP2 hooks for the jit mode of perf inject.
    >
    > > > IIRC the different in the offsets came from 'perf inject' not preserving
    > > > FINISHED_ROUND events.
    >
    > > That's an oversight. Is there code to repipe this event already?
    >
    There is a callback for it already. But now, I remember Adrian
    suggesting, to change
    it to: perf_event__drop_oe(). In fact, if you look at builtin-inject.c
    it has a comment about
    this.

    >
    > right, we need to make it test and use what is available, here:
    >
    > [root@jouet ~]# dnf search alternatives
    > Last metadata expiration check performed 1:01:59 ago on Fri Feb 12
    > 16:38:51 2016.
    > ================================================================= N/S
    > Matched: alternatives
    > ==================================================================
    > galternatives.noarch : Alternatives Configurator
    > ghc-base-unicode-symbols.x86_64 : Unicode alternatives for common
    > functions and operators
    > [root@jouet ~]# rpm -qf `which update-alternatives`
    > chkconfig-1.7-1.fc23.x86_64
    > [root@jouet ~]# rpm -ql chkconfig | grep alternativ
    > /etc/alternatives
    > /usr/sbin/alternatives
    > /usr/sbin/update-alternatives
    > /usr/share/man/man8/alternatives.8.gz
    > /usr/share/man/man8/update-alternatives.8.gz
    > /var/lib/alternatives


    For me on Ubuntu:
    $ dpkg -S /usr/sbin/update-java-alternatives
    java-common: /usr/sbin/update-java-alternatives

    Could you check on Fedora if you do not have that package or its equivalent?

    \
     
     \ /
      Last update: 2016-02-15 03:21    [W:3.782 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site