lkml.org 
[lkml]   [2016]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.3 175/200] crypto: crc32c - Fix crc32c soft dependency
    Date
    4.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jean Delvare <jdelvare@suse.de>

    commit fd7f6727102a1ccf6b4c1dfcc631f9b546526b26 upstream.

    I don't think it makes sense for a module to have a soft dependency
    on itself. This seems quite cyclic by nature and I can't see what
    purpose it could serve.

    OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
    much assumes that some incarnation of the "crc32c" hash algorithm has
    been loaded. Therefore it makes sense to have the soft dependency
    there (as crc-t10dif does.)

    Cc: Tim Chen <tim.c.chen@linux.intel.com>
    Cc: "David S. Miller" <davem@davemloft.net>
    Signed-off-by: Jean Delvare <jdelvare@suse.de>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    crypto/crc32c_generic.c | 1 -
    lib/libcrc32c.c | 1 +
    2 files changed, 1 insertion(+), 1 deletion(-)

    --- a/crypto/crc32c_generic.c
    +++ b/crypto/crc32c_generic.c
    @@ -172,4 +172,3 @@ MODULE_DESCRIPTION("CRC32c (Castagnoli)
    MODULE_LICENSE("GPL");
    MODULE_ALIAS_CRYPTO("crc32c");
    MODULE_ALIAS_CRYPTO("crc32c-generic");
    -MODULE_SOFTDEP("pre: crc32c");
    --- a/lib/libcrc32c.c
    +++ b/lib/libcrc32c.c
    @@ -74,3 +74,4 @@ module_exit(libcrc32c_mod_fini);
    MODULE_AUTHOR("Clay Haapala <chaapala@cisco.com>");
    MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
    MODULE_LICENSE("GPL");
    +MODULE_SOFTDEP("pre: crc32c");

    \
     
     \ /
      Last update: 2016-02-15 01:21    [W:4.090 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site