lkml.org 
[lkml]   [2016]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 11/76] ocfs2: fix SGID not inherited issue
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Junxiao Bi <junxiao.bi@oracle.com>

    commit 854ee2e944b4daf795e32562a7d2f9e90ab5a6a8 upstream.

    Commit 8f1eb48758aa ("ocfs2: fix umask ignored issue") introduced an
    issue, SGID of sub dir was not inherited from its parents dir. It is
    because SGID is set into "inode->i_mode" in ocfs2_get_init_inode(), but
    is overwritten by "mode" which don't have SGID set later.

    Fixes: 8f1eb48758aa ("ocfs2: fix umask ignored issue")
    Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com>
    Cc: Mark Fasheh <mfasheh@suse.de>
    Cc: Joel Becker <jlbec@evilplan.org>
    Acked-by: Srinivas Eeda <srinivas.eeda@oracle.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ocfs2/namei.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    --- a/fs/ocfs2/namei.c
    +++ b/fs/ocfs2/namei.c
    @@ -340,13 +340,11 @@ static int ocfs2_mknod(struct inode *dir
    goto leave;
    }

    - status = posix_acl_create(dir, &mode, &default_acl, &acl);
    + status = posix_acl_create(dir, &inode->i_mode, &default_acl, &acl);
    if (status) {
    mlog_errno(status);
    goto leave;
    }
    - /* update inode->i_mode after mask with "umask". */
    - inode->i_mode = mode;

    handle = ocfs2_start_trans(osb, ocfs2_mknod_credits(osb->sb,
    S_ISDIR(mode),

    \
     
     \ /
      Last update: 2016-02-15 01:01    [W:5.764 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site