lkml.org 
[lkml]   [2016]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 27/64] ALSA: usb-audio: avoid freeing umidi object twice
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andrey Konovalov <andreyknvl@gmail.com>

    commit 07d86ca93db7e5cdf4743564d98292042ec21af7 upstream.

    The 'umidi' object will be free'd on the error path by snd_usbmidi_free()
    when tearing down the rawmidi interface. So we shouldn't try to free it
    in snd_usbmidi_create() after having registered the rawmidi interface.

    Found by KASAN.

    Signed-off-by: Andrey Konovalov <andreyknvl@gmail.com>
    Acked-by: Clemens Ladisch <clemens@ladisch.de>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/usb/midi.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/sound/usb/midi.c
    +++ b/sound/usb/midi.c
    @@ -2291,7 +2291,6 @@ int snd_usbmidi_create(struct snd_card *
    else
    err = snd_usbmidi_create_endpoints(umidi, endpoints);
    if (err < 0) {
    - snd_usbmidi_free(umidi);
    return err;
    }


    \
     
     \ /
      Last update: 2016-02-15 00:41    [W:2.204 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site