Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH RFC 1/3] net: bridge: log state when setting it | Date | Sat, 13 Feb 2016 16:49:45 -0500 |
| |
Hi Ido,
Ido Schimmel <idosch@mellanox.com> writes:
> Fri, Feb 12, 2016 at 11:34:18PM IST, vivien.didelot@savoirfairelinux.com wrote: > > Hi Vivien, > >>Every call to br_set_state is followed by a call to br_log_state. >>Directly call it within br_set_state instead. >> >>Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> >>--- > > Maybe I'm missing something, but there are other instances of this > pattern throughout the code, so why not convert them as well? See > br_set_port_state() for example.
Good catch, I'll factorize that and send this as a unique patch then.
Thanks, -v
| |