Messages in this thread | | | Subject | Re: [PATCH] net: phy: spi_ks8995: add dependency on GPIO | From | Helmut Buchsbaum <> | Date | Fri, 12 Feb 2016 13:33:58 +0100 |
| |
On 02/12/2016 11:18 AM, Sudip Mukherjee wrote: > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > with the error: > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > GPIO is now used to reset the switch so we should have a dependency on > GPIOLIB. > > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") > Cc: Helmut Buchsbaum <helmut.buchsbaum@gmail.com> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > drivers/net/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig > index f0a7702..c6a4fe1 100644 > --- a/drivers/net/phy/Kconfig > +++ b/drivers/net/phy/Kconfig > @@ -261,4 +261,4 @@ endif # PHYLIB > > config MICREL_KS8995MA > tristate "Micrel KS8995MA 5-ports 10/100 managed Ethernet switch" > - depends on SPI > + depends on SPI && GPIOLIB > You're definitely right! This somehow slipped through, sorry for that!
| |