lkml.org 
[lkml]   [2016]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] of: resolver: Add missing of_node_get and of_node_put
On Wed, Feb 3, 2016 at 12:09 PM, Amitoj Kaur Chawla
<amitoj1606@gmail.com> wrote:
> In __of_find_node_by_full_name, add an of_node_get when detecting the
> desired element, to ensure that it ends up with a reference count that is
> one greater than on entering the function.
>
> Also in __of_find_node_by_full_name, add an of_node_put on breaking
> out of the for_each_child_of_node loop, to ensure that the reference
> count of the returned value is not double incremented. This change
> was made using Coccinelle.

Pantelis, are you convinced this is correct (albeit somewhat pointless)?

Rob

\
 
 \ /
  Last update: 2016-02-12 00:41    [W:0.053 / U:1.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site