Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH 1/3] usb: USB Type-C Connector Class | Date | Thu, 11 Feb 2016 10:55:16 +0200 |
| |
Oliver Neukum <oneukum@suse.com> writes: > On Tue, 2016-02-09 at 19:01 +0200, Heikki Krogerus wrote: >> The purpose of this class is to provide unified interface >> for user space to get the status and basic information about >> USB Type-C Connectors in the system, control data role >> swapping, and when USB PD is available, also power role >> swapping and Altenate Modes. >> >> The class will export the following interfaces for every >> USB Type-C Connector in the system to sysfs: >> >> 1. connected - Connection status of the connector >> 2. alternate_mode - The current Alternate Mode >> 3. alternate_modes - Lists all Alternate Modes the connector supports > > These names are a bit problematic, as they are too similar. > How about > > current_alternate_mode > potential_alternate_modes
available_ ?
>> 4. partner_alt_modes - Lists partner's Alternate Modes when connected
partner_alternate_modes ? (it's a file name, we can spell it out)
>> 5. partner_type - Can be USB, Charger, Alt Mode or Accessory >> 6. data_role - The current data role, host or device >> 7. data_roles - Data roles supported by the connector
current_data_role available_data_roles
>> 8. power_role - Connector's current power role, source or sink >> 9. power_roles - Power roles supported by the connector
ditto...
>> 10. power_operation_mode - The current power level in use >> 11. usb_pd - yes if the connector supports USB PD.
supports_usb_power_delivery ?
>> 12. audio_accessory - yes if the connector supports Audio Accessory
supports_audio_accessory
>> 13. debug_accessory - yes if the connector supports Debug Accessory
supports_debug_accessory
> Doesn't this need locking? > And why wouldn't user space want to preselect a mode?
isn't USB always the default mode ?
-- balbi [unhandled content-type:application/pgp-signature] | |