Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Thu, 11 Feb 2016 21:21:05 +0800 | Subject | Re: [PATCH v2 5/5] pinctrl: sunxi: Use pin number when calling sunxi_pmx_set |
| |
Hi,
On Thu, Feb 11, 2016 at 9:17 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Feb 2, 2016 at 10:21 PM, Krzysztof Adamski <k@japko.eu> wrote: > >> sunxi_pmx_set accepts pin number and then calculates offset by >> subtracting pin_base from it. sunxi_pinctrl_gpio_get, on the other hand, >> gets offset so we have to convert it to pin number so we won't get >> negative value in sunxi_pmx_set. >> >> This was only used on A10 so far, where there is only one GPIO chip with >> pin_base set to 0 so it didn't matter. However H3 also requires this >> workaround but have two pinmux sections, triggering problem for PL port. >> >> Signed-off-by: Krzysztof Adamski <k@japko.eu> > > Waiting for Maxime to review this. I guess this patch can be merged > independently of the other patches?
FYI there's a v4 of this patch that both Maxime and I acked.
ChenYu
| |