lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 6/7] ibmvscsi: Add endian conversions to sysfs attribute show functions
    Date
    The values returned by the show functions for the host os_type,
    mad_version, and partition_number attributes get their values
    directly from the madapter_info struct whose associated fields are
    __be32 typed. Added endian conversion to ensure these values are
    sane on LE platforms.

    Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
    Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
    ---
    drivers/scsi/ibmvscsi/ibmvscsi.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
    index e8d4af5..6025481 100644
    --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
    +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
    @@ -1983,7 +1983,7 @@ static ssize_t show_host_partition_number(struct device *dev,
    int len;

    len = snprintf(buf, PAGE_SIZE, "%d\n",
    - hostdata->madapter_info.partition_number);
    + be32_to_cpu(hostdata->madapter_info.partition_number));
    return len;
    }

    @@ -2003,7 +2003,7 @@ static ssize_t show_host_mad_version(struct device *dev,
    int len;

    len = snprintf(buf, PAGE_SIZE, "%d\n",
    - hostdata->madapter_info.mad_version);
    + be32_to_cpu(hostdata->madapter_info.mad_version));
    return len;
    }

    @@ -2022,7 +2022,8 @@ static ssize_t show_host_os_type(struct device *dev,
    struct ibmvscsi_host_data *hostdata = shost_priv(shost);
    int len;

    - len = snprintf(buf, PAGE_SIZE, "%d\n", hostdata->madapter_info.os_type);
    + len = snprintf(buf, PAGE_SIZE, "%d\n",
    + be32_to_cpu(hostdata->madapter_info.os_type));
    return len;
    }

    --
    2.5.0
    \
     
     \ /
      Last update: 2016-02-11 03:01    [W:5.838 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site