| Date | Wed, 10 Feb 2016 13:11:19 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 13/23] perf hists: Support filtering in hierarchy mode |
| |
On Fri, Feb 05, 2016 at 10:01:45PM +0900, Namhyung Kim wrote:
SNIP
> + /* force to go to sibling in the hierarchy */ > + saved_unfolded = h->unfolded; > + h->unfolded = false; > + > + nd = rb_hierarchy_next(&h->rb_node); > + h->unfolded = saved_unfolded; > + } > + } > + > + /* resort output (top-level entries only) */ > + nd = rb_first(&hists->entries); > + while (nd) { > + struct hist_entry *h = rb_entry(nd, struct hist_entry, rb_node); > + > + nd = rb_next(nd); > + rb_erase(&h->rb_node, &hists->entries); > + > + __hists__insert_output_entry(&tmp, h, 0, false); > + }
what's the purpose of this resort? the only affect I see is to recalculate callchains
thanks, jirka
|