Messages in this thread | | | Date | Tue, 2 Feb 2016 08:53:47 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH V2 01/16] PM / OPP: get/put regulators from OPP core |
| |
On 01-02-16, 18:29, Stephen Boyd wrote: > I'm still lost why we need this API. When the OPP is torn down we > can call regulator_put there instead. The same style seems to be > done for supported hw, and prop_name, which doesn't make any > sense either. Just tear everything down when there aren't any > more OPPs in the table.
I explained that earlier as well, but you never replied to that :) Let me paste that again here:
Consider this case: - Platform code sets regulator for cpuX (Create OPP-table struct and set regulator) - insmod cpufreq-dt.ko (Fill OPP table) - rmmod cpufreq-dt.ko (Remove OPP table and struct, according to your suggestion) - insmod cpufreq-dt.ko (No regulator found).
The platform code is supposed to set regulator, supported-hw, prop-name only once from some init-code. And it should just work out of the box after that. And so these calls are really required.
-- viresh
| |