lkml.org 
[lkml]   [2016]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] clkdev: add devm_get_clk_from_child()
    On Mon, Dec 05, 2016 at 05:23:20AM +0000, Kuninori Morimoto wrote:
    >
    > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
    >
    > Some driver is using this type of DT bindings for clock (more detail,
    > see ${LINUX}/Documentation/devicetree/bindings/sound/simple-card.txt).
    >
    > sound_soc {
    > ...
    > cpu {
    > clocks = <&xxx>;
    > ...
    > };
    > codec {
    > clocks = <&xxx>;
    > ...
    > };
    > };
    >
    > Current driver in this case uses of_clk_get() for each node, but there
    > is no devm_of_clk_get() today.
    > OTOH, the problem of having devm_of_clk_get() is that it encourages the
    > use of of_clk_get() when clk_get() is more desirable.
    >
    > Thus, this patch adds new devm_get_clk_from_chile() which explicitly
    > reads as get a clock from a child node of this device.
    > By this function, we can also use this type of DT bindings
    >
    > sound_soc {
    > clocks = <&xxx>, <&xxx>;
    > clock-names = "cpu", "codec";
    > ...
    > cpu {
    > ...
    > };
    > codec {
    > ...
    > };
    > };
    >
    > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

    This looks lots better, thanks.

    Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

    --
    RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
    FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
    according to speedtest.net.

    \
     
     \ /
      Last update: 2016-12-09 21:33    [W:4.130 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site