Messages in this thread Patch in this message | | | From | Kirtika Ruchandani <> | Subject | [PATCH] memremap: Remove unused align_* variables | Date | Wed, 7 Dec 2016 23:42:58 -0800 |
| |
Commit eb7d78c9e7f6 introduced align_start, align_size and align_end variables in pgmap_radix_release() but did not use them. Compiling with W=1 gives the following harmless warning, fix it to reduce the noise with W=1 in the kernel.
kernel/memremap.c: In function ‘pgmap_radix_release’: kernel/memremap.c:199:48: warning: variable ‘align_end’ set but not used [-Wunused-but-set-variable]
The call to resource_size has no side-effects and is safe to remove.
Fixes: eb7d78c9e7f6 ("devm_memremap_pages: fix vmem_altmap lifetime + alignment handling") Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Kirtika Ruchandani <kirtika@chromium.org> --- kernel/memremap.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/kernel/memremap.c b/kernel/memremap.c index b501e39..8dde681 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -196,11 +196,7 @@ EXPORT_SYMBOL(put_zone_device_page);
static void pgmap_radix_release(struct resource *res) { - resource_size_t key, align_start, align_size, align_end; - - align_start = res->start & ~(SECTION_SIZE - 1); - align_size = ALIGN(resource_size(res), SECTION_SIZE); - align_end = align_start + align_size - 1; + resource_size_t key;
mutex_lock(&pgmap_lock); for (key = res->start; key <= res->end; key += SECTION_SIZE) -- 2.8.0.rc3.226.g39d4020
| |