lkml.org 
[lkml]   [2016]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging
On Thu, Dec 01, 2016 at 04:41:26PM -0600, Stuart Yoder wrote:
> Move the source files out of staging into their final locations:
> -include files in drivers/staging/fsl-mc/include go to include/linux/fsl
> -irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
> -source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
> -README.txt, providing and overview of DPAA goes to
> Documentation/dpaa2/overview.txt
> -update MAINTAINERS with new location
>
> Delete other remaining staging files-- Makefile, Kconfig, TODO

Ok, given that I haven't ever reviewed this code, I had a few questions
that I couldn't easily figure out by looking at your code:
- what is the lifecycle of your 'struct device' usage? Who
creates it, who frees it, and who accesses it?
- do you have any Documentation/ABI entries?
- root_dprc_count, why are you using an atomic variable for
this? What is it for other than "look, I'm running!"?
- don't call pr_info() in fsl_mc_bus_driver_init(), no need to
say anything if all goes well. Same goes with random
dev_info() calls, please remove.

That's good enough for now, I think the answer to the first question is
going to cause more to come out :)

thanks,

greg k-h

\
 
 \ /
  Last update: 2016-12-07 16:54    [W:1.176 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site