lkml.org 
[lkml]   [2016]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/1] cpufreq: Fix NULL pointer comparison warning
On Tue, Dec 6, 2016 at 11:17 AM, Mohamed Wasif <m.wasif@samsung.com> wrote:
> Replace direct comparisons to NULL
> This problem was detected by checkpatch.
>
> Signed-off-by: Mohamed Wasif <m.wasif@samsung.com>
> ---
> drivers/cpufreq/cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 6e6c1fb..ca3542e 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -590,7 +590,7 @@ static int cpufreq_parse_governor(char *str_governor, unsigned int *policy,
>
> t = find_governor(str_governor);
>
> - if (t == NULL) {
> + if (!t) {
> int ret;
>
> mutex_unlock(&cpufreq_governor_mutex);
> @@ -601,7 +601,7 @@ static int cpufreq_parse_governor(char *str_governor, unsigned int *policy,
> t = find_governor(str_governor);
> }
>
> - if (t != NULL) {
> + if (t) {
> *governor = t;
> err = 0;
> }
> --

The code is correct as is and this patch doesn't fix anything.

Besides, you are supposed to run checkpatch against *patches* and not
against existing code.

Thanks,
Rafael

\
 
 \ /
  Last update: 2016-12-06 22:05    [W:0.055 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site