lkml.org 
[lkml]   [2016]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] Staging: dgnc: dgnc_*.c: Use usleep_range over udelay to improve coalescing processor wakeups
From
Date

> On Tue, Dec 06, 2016 at 09:59:58AM +0100, Shiva Kerdel wrote:
>> In most cases, usleep_range is better than udelay, as the precise wakeup
>> from udelay is unnecessary.
> But, udelay does something different than usleep, are you sure you
> should be giving up the cpu at this point in time?
>
> Are you sure you are even in a function that is allowed to sleep? I
> don't think that is the case for all of these at all, sorry, unless you
> have the hardware to test this change, I can't take it.
>
> greg k-h
I wasn't aware of this, thank you for pointing out.
Since I don't have this hardware, I'm unable to test the changes.

Shiva Kerdel

\
 
 \ /
  Last update: 2016-12-06 11:05    [W:0.060 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site