Messages in this thread | | | Subject | Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration | From | Netanel Belgazal <> | Date | Mon, 5 Dec 2016 20:32:58 +0200 |
| |
On 12/05/2016 06:20 AM, Matt Wilson wrote: > On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: >> ENA default hash configure IPv4_frag hash twice instead of > configure -> configures. You may want to include "erroneously". What > is the consequence of this bug? I'll fix and I'll add explain the effect of this bug.
> >> configure non ip packets. > configuring non-IP packets.
OK. > > --msw > >> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com> >> --- >> drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c >> index 3066d9c..46aad3a 100644 >> --- a/drivers/net/ethernet/amazon/ena/ena_com.c >> +++ b/drivers/net/ethernet/amazon/ena/ena_com.c >> @@ -2184,7 +2184,7 @@ int ena_com_set_default_hash_ctrl(struct ena_com_dev *ena_dev) >> hash_ctrl->selected_fields[ENA_ADMIN_RSS_IP4_FRAG].fields = >> ENA_ADMIN_RSS_L3_SA | ENA_ADMIN_RSS_L3_DA; >> >> - hash_ctrl->selected_fields[ENA_ADMIN_RSS_IP4_FRAG].fields = >> + hash_ctrl->selected_fields[ENA_ADMIN_RSS_NOT_IP].fields = >> ENA_ADMIN_RSS_L2_DA | ENA_ADMIN_RSS_L2_SA; >> >> for (i = 0; i < ENA_ADMIN_RSS_PROTO_NUM; i++) {
| |