lkml.org 
[lkml]   [2016]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 net 12/20] net/ena: reduce the severity of ena printouts
    Date
    Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
    ---
    drivers/net/ethernet/amazon/ena/ena_com.c | 27 +++++++++++++++++----------
    drivers/net/ethernet/amazon/ena/ena_netdev.c | 14 +++++++++++---
    2 files changed, 28 insertions(+), 13 deletions(-)

    diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
    index f1e4f04..4147d6e 100644
    --- a/drivers/net/ethernet/amazon/ena/ena_com.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_com.c
    @@ -785,7 +785,7 @@ static int ena_com_get_feature_ex(struct ena_com_dev *ena_dev,
    int ret;

    if (!ena_com_check_supported_feature_id(ena_dev, feature_id)) {
    - pr_info("Feature %d isn't supported\n", feature_id);
    + pr_debug("Feature %d isn't supported\n", feature_id);
    return -EPERM;
    }

    @@ -1127,7 +1127,13 @@ int ena_com_execute_admin_command(struct ena_com_admin_queue *admin_queue,
    comp_ctx = ena_com_submit_admin_cmd(admin_queue, cmd, cmd_size,
    comp, comp_size);
    if (unlikely(IS_ERR(comp_ctx))) {
    - pr_err("Failed to submit command [%ld]\n", PTR_ERR(comp_ctx));
    + if (comp_ctx == ERR_PTR(-ENODEV))
    + pr_debug("Failed to submit command [%ld]\n",
    + PTR_ERR(comp_ctx));
    + else
    + pr_err("Failed to submit command [%ld]\n",
    + PTR_ERR(comp_ctx));
    +
    return PTR_ERR(comp_ctx);
    }

    @@ -1918,7 +1924,7 @@ int ena_com_set_dev_mtu(struct ena_com_dev *ena_dev, int mtu)
    int ret;

    if (!ena_com_check_supported_feature_id(ena_dev, ENA_ADMIN_MTU)) {
    - pr_info("Feature %d isn't supported\n", ENA_ADMIN_MTU);
    + pr_debug("Feature %d isn't supported\n", ENA_ADMIN_MTU);
    return -EPERM;
    }

    @@ -1971,8 +1977,8 @@ int ena_com_set_hash_function(struct ena_com_dev *ena_dev)

    if (!ena_com_check_supported_feature_id(ena_dev,
    ENA_ADMIN_RSS_HASH_FUNCTION)) {
    - pr_info("Feature %d isn't supported\n",
    - ENA_ADMIN_RSS_HASH_FUNCTION);
    + pr_debug("Feature %d isn't supported\n",
    + ENA_ADMIN_RSS_HASH_FUNCTION);
    return -EPERM;
    }

    @@ -2135,7 +2141,8 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev)

    if (!ena_com_check_supported_feature_id(ena_dev,
    ENA_ADMIN_RSS_HASH_INPUT)) {
    - pr_info("Feature %d isn't supported\n", ENA_ADMIN_RSS_HASH_INPUT);
    + pr_debug("Feature %d isn't supported\n",
    + ENA_ADMIN_RSS_HASH_INPUT);
    return -EPERM;
    }

    @@ -2293,8 +2300,8 @@ int ena_com_indirect_table_set(struct ena_com_dev *ena_dev)

    if (!ena_com_check_supported_feature_id(
    ena_dev, ENA_ADMIN_RSS_REDIRECTION_TABLE_CONFIG)) {
    - pr_info("Feature %d isn't supported\n",
    - ENA_ADMIN_RSS_REDIRECTION_TABLE_CONFIG);
    + pr_debug("Feature %d isn't supported\n",
    + ENA_ADMIN_RSS_REDIRECTION_TABLE_CONFIG);
    return -EPERM;
    }

    @@ -2565,8 +2572,8 @@ int ena_com_init_interrupt_moderation(struct ena_com_dev *ena_dev)

    if (rc) {
    if (rc == -EPERM) {
    - pr_info("Feature %d isn't supported\n",
    - ENA_ADMIN_INTERRUPT_MODERATION);
    + pr_debug("Feature %d isn't supported\n",
    + ENA_ADMIN_INTERRUPT_MODERATION);
    rc = 0;
    } else {
    pr_err("Failed to get interrupt moderation admin cmd. rc: %d\n",
    diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    index 5625007..7ae1fce 100644
    --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
    @@ -570,6 +570,7 @@ static void ena_free_all_rx_bufs(struct ena_adapter *adapter)
    */
    static void ena_free_tx_bufs(struct ena_ring *tx_ring)
    {
    + bool print_once = true;
    u32 i;

    for (i = 0; i < tx_ring->ring_size; i++) {
    @@ -581,9 +582,16 @@ static void ena_free_tx_bufs(struct ena_ring *tx_ring)
    if (!tx_info->skb)
    continue;

    - netdev_notice(tx_ring->netdev,
    - "free uncompleted tx skb qid %d idx 0x%x\n",
    - tx_ring->qid, i);
    + if (print_once) {
    + netdev_notice(tx_ring->netdev,
    + "free uncompleted tx skb qid %d idx 0x%x\n",
    + tx_ring->qid, i);
    + print_once = false;
    + } else {
    + netdev_dbg(tx_ring->netdev,
    + "free uncompleted tx skb qid %d idx 0x%x\n",
    + tx_ring->qid, i);
    + }

    ena_buf = tx_info->bufs;
    dma_unmap_single(tx_ring->dev,
    --
    2.7.4
    \
     
     \ /
      Last update: 2016-12-04 14:23    [W:2.625 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site