Messages in this thread | | | Date | Sun, 4 Dec 2016 16:05:04 +0000 | From | Al Viro <> | Subject | Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] |
| |
On Sun, Dec 04, 2016 at 04:38:05AM +0000, Al Viro wrote:
> I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, > especially since the rules are "you need to initialize it for vfs_xgetattr(), > but not for vfs_getattr()" - the names are similar enough for confusion, > and that's not the only such pair.
BTW, after some grepping: you seem to leave ecryptfs_getattr() as-is, which means that flags it had been passed by caller in *stat are not seen by underlying fs. Looks fishy...
| |