lkml.org 
[lkml]   [2016]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: mxs-lradc: fix error handling in mxs_lradc_probe()
> Jonathan Cameron <jic23@kernel.org> hat am 30. Dezember 2016 um 20:09 geschrieben:
>
>
> On 26/12/16 22:04, Stefan Wahren wrote:
> >
> >> Alexey Khoroshilov <khoroshilov@ispras.ru> hat am 23. Dezember 2016 um 23:15 geschrieben:
> >>
> >>
> >> During transition to using devm_input_allocate_device()
> >> goto to resource deallocation block was replaced by return
> >> in case of error in iio_device_register().
> >> That is wrong since resources are left undeallocated.
> >>
> >> Found by Linux Driver Verification project (linuxtesting.org).
> >>
> >> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> >> Fixes: 962ed43a3eac ("iio: mxs-lradc: remove mxs_lradc_ts_unregister")
> >
> > Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
> >
> > But since Ksenija's patch series [1] (which doesn't have this issue) this patch is only relevant for stable.
> It's slightly doubtful as stable material as well unless it causes
> a crash. Obviously failing to clean up isn't good, but its not critical
> enough to justify the churn.
>
> Good find though.
>
> Should you wish to post it to stable and let the stable maintainers make
> a decision feel free to do so.

No, i don't have any plans for that.

>
> Jonathan
> >
> > Thanks
> >
> > [1] - http://marc.info/?l=linux-iio&m=148131774219426&w=2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>

\
 
 \ /
  Last update: 2016-12-30 21:17    [W:0.042 / U:2.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site