Messages in this thread | | | From | Chanwoo Choi <> | Date | Fri, 30 Dec 2016 21:00:48 +0900 | Subject | Re: [PATCH v2 4/8] PM / devfreq: exynos-ppmu: Show the registred device for ppmu device |
| |
2016-12-30 19:35 GMT+09:00 MyungJoo Ham <myungjoo.ham@samsung.com>: > On Wed, Dec 28, 2016 at 8:56 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> This patch just adds the simple log to show the PPMU device's registration >> during the kernel booting. >> >> Cc: Kukjin Kim <kgene@kernel.org> >> Cc: Krzysztof Kozlowski <krzk@kernel.org> >> Cc: Javier Martinez Canillas <javier@osg.samsung.com> >> Cc: linux-samsung-soc@vger.kernel.org >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> drivers/devfreq/event/exynos-ppmu.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c >> index fb3706faf5bd..9b5294d0bff4 100644 >> --- a/drivers/devfreq/event/exynos-ppmu.c >> +++ b/drivers/devfreq/event/exynos-ppmu.c >> @@ -591,7 +591,7 @@ static int exynos_ppmu_parse_dt(struct platform_device *pdev, >> info->ppmu.clk = devm_clk_get(dev, "ppmu"); >> if (IS_ERR(info->ppmu.clk)) { >> info->ppmu.clk = NULL; >> - dev_warn(dev, "cannot get PPMU clock\n"); >> + dev_dbg(dev, "cannot get PPMU clock\n"); > > Do you really want not to emit warning with a clock not found?
The clock is now optional on the exynos-bus.c driver. But we better to keep the warning message. Instead, I'll try to add the clock to PPMU which is missing the clock.
I'll send the next version.
[snip]
-- Best Regards, Chanwoo Choi
| |