lkml.org 
[lkml]   [2016]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]
    On Wed, Nov 23, 2016 at 12:55:51AM +0000, David Howells wrote:

    > -int vfs_getattr_nosec(struct path *path, struct kstat *stat)
    > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat)

    const struct path *, please. Especially since we feed &file->f_path to
    it. And yes, I realize that the same applies to vfs_getattr() in the
    current tree.

    > +int vfs_xgetattr(struct path *path, struct kstat *stat)

    Ditto.

    > +int vfs_getattr(struct path *path, struct kstat *stat)

    Again.

    > +#define __put_timestamp(kts, uts) ( \
    > + __put_user(kts.tv_sec, uts.tv_sec ) || \
    > + __put_user(kts.tv_nsec, uts.tv_nsec ) || \
    > + __put_user(0, uts.__reserved ))

    static inline.

    > +#define KSTAT_ATTR_FS_IOC_FLAGS 0x00000874 /* Attrs corresponding to FS_*_FL flags */

    Err... An explicit hex constant?

    \
     
     \ /
      Last update: 2016-12-04 05:02    [W:4.080 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site