Messages in this thread | | | Date | Sat, 3 Dec 2016 18:15:57 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd |
| |
On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced > > from other functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE? > > I'm looking to drop TPM_DIGEST_SIZE eventually. > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
... in the sense that the changes do not break the compilation and do not produce sparse or cocciheck errors. I guess that should be enough for documentation changes.
/Jarkko
| |