Messages in this thread | | | Date | Sat, 3 Dec 2016 17:30:28 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm: use get_unaligned_be32 unaligned buffer access. |
| |
Hey,
On Thu, Nov 24, 2016 at 03:34:00PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 01:04:54PM +0200, Tomas Winkler wrote: > > Use get_unaligned_be32 as b32_to_cpu doesn't work correctly on > > all platforms for unaligned access. > > > > The fix doesn't cover all the cases as also some cast > > structures have members on unaligned addresses. > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > This looks good to me with the exceptio that was pointed out by Jason. > CC the next version to the linux-security-module. I talked with James > about this at LPC and since this list does not have too many active > reviewers it makes sense to cycle all the non-trivial changes through > that list.
Are you planning to send an updated version of this. Should be a no-brainer to apply.
/Jarkko
| |