lkml.org 
[lkml]   [2016]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: nand: xway: fix build failure
+Hauke

Sudip, Marek,

On Fri, 23 Dec 2016 10:07:23 +0100
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 12/23/2016 09:17 AM, Sudip Mukherjee wrote:
> > The build of mips xway_defconfig was failing with the error:
> >
> > drivers/mtd/nand/xway_nand.c:235:1: warning:
> > data definition has no type or storage class
> > MODULE_DEVICE_TABLE(of, xway_nand_match);
> > ^~~~~~~~~~~~~~~~~~~
> > drivers/mtd/nand/xway_nand.c:235:1: error:
> > type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > [-Werror=implicit-int]
> >
> > It missed to include the header file.
> >
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Acked-by: Marek Vasut <marex@denx.de>

Nack. Hauke already sent a fix for that one, and I'm about to queue it
in my fixes-for-4.10 branch.

Marek, if you want to ack these patches, please review [1] and [2].

Thanks,

Boris

[1]https://patchwork.ozlabs.org/patch/702880/
[2]https://patchwork.ozlabs.org/patch/702879/

>
> > ---
> >
> > Build log of next-20161223 is at:
> > https://travis-ci.org/sudipm-mukherjee/parport/jobs/186246753
> >
> > This error will be fixed but it will now uncover the next error as the
> > build goes on.
> >
> > drivers/mtd/nand/xway_nand.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c
> > index 1f2948c..00168d6 100644
> > --- a/drivers/mtd/nand/xway_nand.c
> > +++ b/drivers/mtd/nand/xway_nand.c
> > @@ -7,6 +7,7 @@
> > * Copyright © 2016 Hauke Mehrtens <hauke@hauke-m.de>
> > */
> >
> > +#include <linux/module.h>
> > #include <linux/mtd/nand.h>
> > #include <linux/of_gpio.h>
> > #include <linux/of_platform.h>
> >
>
>

\
 
 \ /
  Last update: 2016-12-29 17:29    [W:0.041 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site