lkml.org 
[lkml]   [2016]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/4] ocfs2: fix some small problems
Hi Gang, one small comment below:

On Wed, Dec 21, 2016 at 2:20 AM, Gang He <ghe@suse.com> wrote:
> First, move setting fe_done = 1 in spin lock, avoid bring
> any potential race condition. Second, tune mlog message level
> from ERROR to NOTICE, since the message should not belong to
> error message.
>
> Signed-off-by: Gang He <ghe@suse.com>
> ---
> fs/ocfs2/filecheck.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> @@ -545,11 +545,11 @@ static ssize_t ocfs2_filecheck_store(struct kobject *kobj,
> spin_lock(&ent->fs_fcheck->fc_lock);
> if ((ent->fs_fcheck->fc_size >= ent->fs_fcheck->fc_max) &&
> (ent->fs_fcheck->fc_done == 0)) {
> - mlog(ML_ERROR,
> + mlog(ML_NOTICE,
> "Cannot do more file check "
> "since file check queue(%u) is full now\n",
> ent->fs_fcheck->fc_max);
> - ret = -EBUSY;
> + ret = -EAGAIN;

This change wasn't described in the patch header. Granted, from the
message above the change, -EAGAIN certainly seems a more reasonable
return value but it would be good to know whether this was intended
and why.

Thanks,
--Mark

\
 
 \ /
  Last update: 2016-12-28 23:35    [W:0.077 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site