Messages in this thread | | | From | Mark Fasheh <> | Date | Wed, 28 Dec 2016 16:34:08 -0600 | Subject | Re: [PATCH v2 2/4] ocfs2: fix some small problems |
| |
Hi Gang, one small comment below:
On Wed, Dec 21, 2016 at 2:20 AM, Gang He <ghe@suse.com> wrote: > First, move setting fe_done = 1 in spin lock, avoid bring > any potential race condition. Second, tune mlog message level > from ERROR to NOTICE, since the message should not belong to > error message. > > Signed-off-by: Gang He <ghe@suse.com> > --- > fs/ocfs2/filecheck.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > @@ -545,11 +545,11 @@ static ssize_t ocfs2_filecheck_store(struct kobject *kobj, > spin_lock(&ent->fs_fcheck->fc_lock); > if ((ent->fs_fcheck->fc_size >= ent->fs_fcheck->fc_max) && > (ent->fs_fcheck->fc_done == 0)) { > - mlog(ML_ERROR, > + mlog(ML_NOTICE, > "Cannot do more file check " > "since file check queue(%u) is full now\n", > ent->fs_fcheck->fc_max); > - ret = -EBUSY; > + ret = -EAGAIN;
This change wasn't described in the patch header. Granted, from the message above the change, -EAGAIN certainly seems a more reasonable return value but it would be good to know whether this was intended and why.
Thanks, --Mark
| |