lkml.org 
[lkml]   [2016]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] [media] v4l2-async: Delete an error message for a failed memory allocation in v4l2_async_notifier_unregister()
    On Mon, Dec 26, 2016 at 09:45:50PM +0100, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Mon, 26 Dec 2016 19:19:49 +0100
    >
    > The script "checkpatch.pl" pointed information out like the following.
    >
    > WARNING: Possible unnecessary 'out of memory' message
    >
    > Thus fix the affected source code place.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/media/v4l2-core/v4l2-async.c | 5 -----
    > 1 file changed, 5 deletions(-)
    >
    > diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
    > index 277183f2d514..812d0b2a2f73 100644
    > --- a/drivers/media/v4l2-core/v4l2-async.c
    > +++ b/drivers/media/v4l2-core/v4l2-async.c
    > @@ -203,11 +203,6 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier)
    > return;
    >
    > dev = kmalloc_array(n_subdev, sizeof(*dev), GFP_KERNEL);
    > - if (!dev) {
    > - dev_err(notifier->v4l2_dev->dev,
    > - "Failed to allocate device cache!\n");
    > - }
    > -

    I'd leave the empty line where it is.

    Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

    > mutex_lock(&list_lock);
    >
    > list_del(&notifier->list);
    > --
    > 2.11.0
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-media" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html

    --
    Sakari Ailus
    e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk

    \
     
     \ /
      Last update: 2016-12-27 12:48    [W:2.727 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site