Messages in this thread | | | Subject | Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver | From | Shrirang Bagul <> | Date | Tue, 27 Dec 2016 11:29:46 +0800 |
| |
On Mon, 2016-12-19 at 16:44 +0000, Mark Brown wrote: > On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote: > > > All this code seems to be largely a copy-paste of the bytcr_rt5640 machine > > driver and the same comments would apply there. This patch did miss the last > > Yes, there's a lot of room for cleanups in the existing code too (and of > course if there's such a large amount of cut'n'paste that implies that > there should be some code reuse going on). Thank you for the review and valuable comments. Following the discussion so far, I feel the proper way would be to adapt bytcr_rt5660 machine driver to manage RT5660 codec. > > > correction merged by Mark to deal with errors "ASoC: Intel: bytcr_rt5640: > > fallback mechanism if MCLK is not enabled" and the same error handling would > > be needed. > > There was a cut back version of it I thought? Will try and include the MCLK fallback patch in ver. 2 of the patch.[unhandled content-type:application/pgp-signature] | |