lkml.org 
[lkml]   [2016]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V6 04/11] megaraid_sas: SAS3.5 Generic Megaraid Controllers Stream Detection and IO Coalescing
Hi Sasikumar,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20161223]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Sasikumar-Chandrasekaran/megaraid_sas-Updates-for-scsi-next/20161223-103256
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-randconfig-ne0-12231250 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

In file included from include/linux/linkage.h:4:0,
from include/linux/kernel.h:6,
from drivers/scsi/megaraid/megaraid_sas_fusion.c:34:
drivers/scsi/megaraid/megaraid_sas_fusion.c: In function 'megasas_stream_detect':
include/linux/compiler.h:149:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
include/linux/compiler.h:147:23: note: in expansion of macro '__trace_if'
#define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
^~~~~~~~~~
>> drivers/scsi/megaraid/megaraid_sas_fusion.c:1744:3: note: in expansion of macro 'if'
if ((io_info->ldStartBlock != current_sd->next_seq_lba)
^~
drivers/scsi/megaraid/megaraid_sas_fusion.c:1751:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
cmd->io_request->RaidContext.raid_context_g35.stream_detected = true;
^~~

vim +/if +1744 drivers/scsi/megaraid/megaraid_sas_fusion.c

1728 struct STREAM_DETECT *current_sd;
1729 /* find possible stream */
1730 for (i = 0; i < MAX_STREAMS_TRACKED; ++i) {
1731 stream_num =
1732 (*track_stream >> (i * BITS_PER_INDEX_STREAM)) &
1733 STREAM_MASK;
1734 current_sd = &current_ld_sd->stream_track[stream_num];
1735 /* if we found a stream, update the raid
1736 * context and also update the mruBitMap
1737 */
1738 /* boundary condition */
1739 if ((current_sd->next_seq_lba) &&
1740 (io_info->ldStartBlock >= current_sd->next_seq_lba) &&
1741 (io_info->ldStartBlock <= (current_sd->next_seq_lba+32)) &&
1742 (current_sd->is_read == io_info->isRead)) {
1743
> 1744 if ((io_info->ldStartBlock != current_sd->next_seq_lba)
1745 && ((!io_info->isRead) || (!is_read_ahead)))
1746 /*
1747 * Once the API availible we need to change this.
1748 * At this point we are not allowing any gap
1749 */
1750 continue;
1751 cmd->io_request->RaidContext.raid_context_g35.stream_detected = true;
1752 current_sd->next_seq_lba =

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2016-12-23 07:04    [W:0.080 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site