lkml.org 
[lkml]   [2016]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/urgent] perf sched timehist: Enlarge default 'comm_width'
    Commit-ID:  9b8087d72086b249ff744cee237ad12cc5e9255d
    Gitweb: http://git.kernel.org/tip/9b8087d72086b249ff744cee237ad12cc5e9255d
    Author: Namhyung Kim <namhyung@kernel.org>
    AuthorDate: Thu, 22 Dec 2016 15:03:48 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Thu, 22 Dec 2016 16:35:45 -0300

    perf sched timehist: Enlarge default 'comm_width'

    Current default value is 20 but it's easily changed to a bigger value as
    task has a long name and different tid and pid. And it makes the output
    not aligned. So change it to have a large value as summary shows.

    Committer notes:

    Before:

    # perf sched record
    ^C
    # perf sched timehist
    <SNIP>
    40602.770537 [0001] rcuos/2[29] 7.970 0.002 0.020
    40602.771512 [0003] <idle> 0.003 0.000 0.986
    40602.771586 [0001] <idle> 0.020 0.000 1.049
    40602.771606 [0001] qemu-system-x86[3593/3510] 0.000 0.002 0.020
    40602.771629 [0003] qemu-system-x86[3510] 0.000 0.003 0.116
    40602.771776 [0000] <idle> 0.001 0.000 1.892
    <SNIP>

    After:

    # perf sched timehist
    <SNIP>
    40602.770537 [0001] rcuos/2[29] 7.970 0.002 0.020
    40602.771512 [0003] <idle> 0.003 0.000 0.986
    40602.771586 [0001] <idle> 0.020 0.000 1.049
    40602.771606 [0001] qemu-system-x86[3593/3510] 0.000 0.002 0.020
    40602.771629 [0003] qemu-system-x86[3510] 0.000 0.003 0.116
    <SNIP>

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/20161222060350.17655-1-namhyung@kernel.org
    [ Split from a larger patch ]
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-sched.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
    index 020f9c9..c65f16c 100644
    --- a/tools/perf/builtin-sched.c
    +++ b/tools/perf/builtin-sched.c
    @@ -1775,7 +1775,7 @@ static u64 perf_evsel__get_time(struct perf_evsel *evsel, u32 cpu)
    return r->last_time[cpu];
    }

    -static int comm_width = 20;
    +static int comm_width = 30;

    static char *timehist_get_commstr(struct thread *thread)
    {
    \
     
     \ /
      Last update: 2016-12-23 20:29    [W:3.022 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site