Messages in this thread | | | Date | Thu, 22 Dec 2016 10:11:00 +0800 | From | Jike Song <> | Subject | Re: [PATCH 0/4] vfio-mdev: Clean namespace and better define ABI |
| |
On 12/22/2016 07:27 AM, Alex Williamson wrote: > Cleanup the namespace a bit by prefixing structures with mdev_ and > also more concretely define the mdev interface. Structs with comments > defining which fields are private vs public tempts poor behavior, > especially for an interface where we expect out of tree vendor drivers.
Personally I like this series :)
Side notes: 1) There is also Documentation to be updated; 2) your mail address in Author field is @nuc.home?
-- Thanks, Jike
> > --- > > Alex Williamson (4): > vfio-mdev: Remove an unused structure element > vfio-mdev: de-polute the namespace, rename parent_device & parent_ops > vfio-mdev: Make mdev_parent private > vfio-mdev: Make mdev_device private and abstract interfaces > > > drivers/gpu/drm/i915/gvt/kvmgt.c | 22 +++++++------ > drivers/vfio/mdev/mdev_core.c | 64 ++++++++++++++++++++++++++++++-------- > drivers/vfio/mdev/mdev_private.h | 28 +++++++++++++++-- > drivers/vfio/mdev/mdev_sysfs.c | 8 ++--- > drivers/vfio/mdev/vfio_mdev.c | 12 ++++--- > include/linux/mdev.h | 54 +++++++------------------------- > samples/vfio-mdev/mtty.c | 28 +++++++++-------- > 7 files changed, 123 insertions(+), 93 deletions(-) > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
| |