lkml.org 
[lkml]   [2016]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"
From
Date
Hello.

On 21/12/16 19:30, Chris Healy wrote:
>
>
> On Dec 21, 2016 5:11 AM, "Stefan Schmidt" <stefan@osg.samsung.com
> <mailto:stefan@osg.samsung.com>> wrote:
>
> Hello.
>
>
> On 19/12/16 00:25, Andrey Smirnov wrote:
>
> Driver code never touches "rstn" signal in atomic context, so
> there's
> no need to implicitly put such restriction on it by using
> gpio_set_value
> to manipulate it. Replace gpio_set_value to
> gpio_set_value_cansleep to
> fix that.
>
>
> We need to make sure we are not assuming it can be called in such a
> context in the future now. But that is something we can worry about
> if it comes up.
>
>
> As a an example of where such restriction might be inconvenient,
> consider a hardware design where "rstn" is connected to a pin of
> I2C/SPI
> GPIO expander chip.
>
>
> Is this a real life issue you run into?
>
>
> I have a platform with this configuration. The DTS for the platform is
> in the process of being mainlined right now.

Thanks for letting us know. What platform is that? I'm always interested
in hearing about devices that use the Linux ieee802154 subsystem. :)

regards
Stefan Schmidt

\
 
 \ /
  Last update: 2016-12-21 22:01    [W:0.968 / U:0.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site