Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 21 Dec 2016 11:45:05 -0800 | Subject | Re: [PATCHv6 2/7] printk: rename nmi.c and exported api |
| |
On Wed, Dec 21, 2016 at 6:36 AM, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote: > A preparation patch for printk_safe work. No functional change. > - rename nmi.c to print_safe.c > - rename exported functions to have a `printk_safe' prefix.
I dislike this patch.
It's _mostly_ ok, but the nmi naming is nasty.
Either "printk_nmi()" or "printk_safe" is fine, but doing *both* is stupid and wrong. And you do both in a couple of places.
So please keep the printk_nmi_enter/exit() naming. Because "printk_safe_nmi_enter/exit()" is just stupid. It's about nmi entry. The "safe" part is simply an implementation detail.
Linus
| |