Messages in this thread | | | Date | Wed, 21 Dec 2016 16:22:30 +0100 | From | Andrew Lunn <> | Subject | Re: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports |
| |
On Wed, Dec 21, 2016 at 02:25:19PM +0100, Uwe Kleine-König wrote: > On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > > are not limiting link's speed and the ports will be configured to their > > > maximux speed as a default) > > > > > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > > > > With this patch, ports connected to revB's second switch stop working. > > This is probably because without a fixed-link node the phy-mode setting > isn't applied by the driver.
Yep, bad suggestion from me. If the phy-mode was not needed, then you can drop the fixed-link. With the phy-mode, you also need the fixed link.
Sorry for the wasted time,
Andrew
| |