Messages in this thread | | | Subject | Re: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c | From | Hauke Mehrtens <> | Date | Wed, 21 Dec 2016 16:19:00 +0100 |
| |
On 12/20/2016 10:18 PM, Paul Gortmaker wrote: > In commit d47529b2e9fe0ec2eb1f072afad8849f52e385c4 ("gpio: don't > include module.h in shared driver header") we fixed a bunch of > implicit includes and then did what the shortlog says -- remove > module.h from a gpio header. > > In parallel, commit 024366750c2e04fdcda8bca685194ef0196b35fe > ("mtd: nand: xway: convert to normal platform driver") added new > modular function calls to a file that now became relying on the > above module.h presence in the gpio header, since it did not > explicitly include module.h header for them as part of the change. > > The problem only appears when the two dev streams are merged. > > Since the file is tristate, the fix is obvious -- it needs an > explicit include of module.h header.
Hi Paul,
the xway nand driver does not build as a module, so I made it bool, this patch: http://lists.infradead.org/pipermail/linux-mtd/2016-December/070800.html And then made it use the non module versions here: http://lists.infradead.org/pipermail/linux-mtd/2016-December/070801.html
In the beginning I also came up with the same patch as you, but the mtd people suggested to do it differently. I hope my two patches are on their way into Linus tree.
Hauke
| |