Messages in this thread Patch in this message | | | From | Hans de Goede <> | Subject | [PATCH v2 10/12] power: supply: axp288_charger: Fix wrong regmap_update_bits | Date | Wed, 21 Dec 2016 15:36:55 +0100 |
| |
To set a bit to 1 one needs to pass the mask for the bit to set as second argument into regmap_update_bits, not "1".
Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/power/supply/axp288_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/axp288_charger.c b/drivers/power/supply/axp288_charger.c index 42a6b92..d3932cd 100644 --- a/drivers/power/supply/axp288_charger.c +++ b/drivers/power/supply/axp288_charger.c @@ -706,7 +706,7 @@ static int charger_init_hw_regs(struct axp288_chrg_info *info) /* Do not turn-off charger o/p after charge cycle ends */ ret = regmap_update_bits(info->regmap, AXP20X_CHRG_CTRL2, - CNTL2_CHG_OUT_TURNON, 1); + CNTL2_CHG_OUT_TURNON, CNTL2_CHG_OUT_TURNON); if (ret < 0) { dev_err(&info->pdev->dev, "register(%x) write error(%d)\n", AXP20X_CHRG_CTRL2, ret); -- 2.9.3
| |