Messages in this thread | | | Date | Tue, 20 Dec 2016 17:44:06 +0000 | From | Roger Pau Monné <> | Subject | Re: [PATCH] xen/blkback: use rb_entry() |
| |
On Tue, Dec 20, 2016 at 11:47:03AM -0500, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 20, 2016 at 10:02:19PM +0800, Geliang Tang wrote: > > To make the code clearer, use rb_entry() instead of container_of() to > > deal with rbtree. > > That is OK but I think 'container_of' is more clear. > > Roger, thoughts?
I think so, container_of is a global macro that's widely used and everyone knows, rb_entry OTOH it's not and it's use doesn't really simply the code at all. I'm not really opposed, but it seems kind of a pointless change (not that it's wrong).
Roger.
| |