lkml.org 
[lkml]   [2016]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] RDS: use rb_entry()
    On Tue, Dec 20, 2016 at 10:02:18PM +0800, Geliang Tang wrote:
    > To make the code clearer, use rb_entry() instead of container_of() to
    > deal with rbtree.
    >
    > Signed-off-by: Geliang Tang <geliangtang@gmail.com>
    > ---
    > net/rds/rdma.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)

    Thanks,
    Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

    >
    > diff --git a/net/rds/rdma.c b/net/rds/rdma.c
    > index 4c93bad..ea96114 100644
    > --- a/net/rds/rdma.c
    > +++ b/net/rds/rdma.c
    > @@ -135,7 +135,7 @@ void rds_rdma_drop_keys(struct rds_sock *rs)
    > /* Release any MRs associated with this socket */
    > spin_lock_irqsave(&rs->rs_rdma_lock, flags);
    > while ((node = rb_first(&rs->rs_rdma_keys))) {
    > - mr = container_of(node, struct rds_mr, r_rb_node);
    > + mr = rb_entry(node, struct rds_mr, r_rb_node);
    > if (mr->r_trans == rs->rs_transport)
    > mr->r_invalidate = 0;
    > rb_erase(&mr->r_rb_node, &rs->rs_rdma_keys);
    > --
    > 2.9.3
    >
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2016-12-20 15:22    [W:3.070 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site