Messages in this thread | | | Date | Tue, 20 Dec 2016 11:36:58 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/1] kernel: futex: fixed to else and initcall |
| |
On Tue, 20 Dec 2016, Ozgur Karatas wrote: > 20.12.2016, 11:21, "Thomas Gleixner" <tglx@linutronix.de>: > > On Mon, 19 Dec 2016, Ozgur Karatas wrote: > > > >> else doesn't need to be used, if should be enclosed in parentheses. > > > > Really? > > > > > > So you change the code from > > > > if (err < 0) > > return err; > > else > > err = 0; > > > > to > > > > if (err < 0) { > > return err; > > err = 0; > > } > > > > How on earth is that equivivalent and how would that 'err = 0;' statement > > be ever executed? > > Oh my god, I missed this point, sorry! > Thank you so much for correct me. > > This "return err;" will give to "err" and err defined to err = "0". > Then removed to "else" and return = err; and should it be like this? > > #define err = 0; > > if (err < 0) { > return err; > }
I seriously recommend to take a basic C course first before trying to change code in the kernel.
Thanks,
tglx
| |